Bug 59349

Summary: Enforce strict mode of OwnPtr
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, benjamin, darin, eric, jamesr, kbr
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
1) fix JSC
none
2) patch for WebCore jamesr: review-

Benjamin Poulain
Reported 2011-04-25 14:55:04 PDT
For the sprint. Refactor the code to get rid of implicit conversion and get rid of LOOSE_OWN_PTR.
Attachments
1) fix JSC (5.43 KB, patch)
2011-04-25 15:00 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
2) patch for WebCore (4.03 KB, patch)
2011-04-26 18:26 PDT, Benjamin Poulain 		jamesr: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2011-04-25 15:00:35 PDT
Created attachment 90951 [details] 1) fix JSC
Benjamin Poulain
Comment 2 2011-04-25 15:25:36 PDT
Comment on attachment 90951 [details] 1) fix JSC Clearing the flags as the hackthon patches already conflict with this.
Benjamin Poulain
Comment 3 2011-04-26 18:26:55 PDT
Created attachment 91202 [details] 2) patch for WebCore Fix the remaining dependencies after the sprint. With this, the Mac port build with the strict mode.
Eric Seidel (no email)
Comment 4 2011-04-26 18:35:14 PDT
I think the shadow part of the patch may be wrong. Also kbr brought up some concerns about OwnPtr(OwnPtr&)... so I think others more involved in the effort should review this. I'm tempted to r- this based on my believe that the shadow stuff is wrong (jamesr posted a related patch).
James Robinson
Comment 5 2011-04-26 18:46:08 PDT
Comment on attachment 91202 [details] 2) patch for WebCore This won't apply cleanly to ToT (I've fixed many of these issues). Please update and repost if there are any other changes.
Benjamin Poulain
Comment 6 2011-04-30 22:48:48 PDT
I can close this...the problem is mostly addressed upstream already.
Note You need to log in before you can comment on or make changes to this bug.