Bug 59339

Summary:

WebCore build on Windows should include windows.h in its precompiled header to speed builds

Product:

WebKit

Reporter:

Steve Falkenburg <sfalken>

Component:

New Bugs

Assignee:

Steve Falkenburg <sfalken>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	bweinstein: review+

Description Steve Falkenburg 2011-04-25 13:39:23 PDT

WebCore build on Windows should include windows.h in its precompiled header to speed builds

Comment 1 Steve Falkenburg 2011-04-25 13:45:55 PDT

Created attachment 90938 [details]
Patch

Comment 2 WebKit Review Bot 2011-04-25 13:47:36 PDT

Attachment 90938 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/WebCorePrefix.h:135:  "windows.h" already included at Source/WebCore/WebCorePrefix.h:120  [build/include] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Steve Falkenburg 2011-04-25 13:51:38 PDT

Committed r84797: <http://trac.webkit.org/changeset/84797>