Bug 59324

Summary:

[Windows and Leopard Tests] media/invalid-media-url-crash.html failing since r84762

Product:

WebKit

Reporter:

Jessie Berlin <jberlin>

Component:

Page Loading

Assignee:

Maciej Stachowiak <mjs>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, aroben, eric.carlson, inferno, jberlin, mjs, staikos

Priority:

Keywords:

LayoutTestFailure, PlatformOnly, Regression

Version:

528+ (Nightly build)

Hardware:

All

OS:

Windows 7

Attachments:

Description	Flags
Patch	abarth: review+

Jessie Berlin

Reported 2011-04-25 08:42:46 PDT

http://trac.webkit.org/changeset/84762 http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r84760%20(12065)/results.html http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r84762%20(12066)/results.html Interestingly, the WK1 bots are failing in a different way than the WK2 bots: WK1: http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r84775%20(12075)/media/invalid-media-url-crash-pretty-diff.html http://build.webkit.org/results/Windows%20XP%20Debug%20(Tests)/r84775%20(28015)/media/invalid-media-url-crash-pretty-diff.html WK2: http://build.webkit.org/results/Windows%207%20Release%20(WebKit2%20Tests)/r84776%20(5961)/media/invalid-media-url-crash-pretty-diff.html

Attachments
Patch (1.88 KB, patch) 2011-04-26 14:42 PDT, Maciej Stachowiak	abarth: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Jessie Berlin

Comment 1 2011-04-26 12:42:43 PDT

Added the test to the Windows skipped list in http://trac.webkit.org/changeset/84942

Jessie Berlin

Comment 2 2011-04-26 13:19:33 PDT

This is also timing out on Leopard as of r84762 and is already on the mac-snowleopard skipped list. I am starting to wonder if the right thing to do is disable this test.

Alexey Proskuryakov

Comment 3 2011-04-26 13:27:04 PDT

This test needs to be updated now that we treat http:aa\0%aa#aa as valid URL. But I'm not sure what URLs will stay reliably invalid.

Alexey Proskuryakov

Comment 4 2011-04-26 13:28:19 PDT

I'm wondering how many other tests used this technique, and no longer test what they were supposed to.

Jessie Berlin

Comment 5 2011-04-26 13:40:49 PDT

Maciej is going to try to first fix the test replacing the invalid URL with !:, which should really be invalid, and then going to try to find out why the check for invalid URLs was added in the code.

Maciej Stachowiak

Comment 6 2011-04-26 14:42:20 PDT

Created attachment 91166 [details] Patch

Maciej Stachowiak

Comment 7 2011-04-26 14:43:45 PDT

Committed r84959: <http://trac.webkit.org/changeset/84959>

Note You need to log in before you can comment on or make changes to this bug.