Summary: | Wrong encoding used for http://www.miel.ru | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||||
Component: | DOM | Assignee: | Alexey Proskuryakov <ap> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | ||||||||||
Priority: | P2 | ||||||||||
Version: | 420+ | ||||||||||
Hardware: | Mac | ||||||||||
OS: | OS X 10.4 | ||||||||||
URL: | http://www.miel.ru | ||||||||||
Attachments: |
|
Description
Alexey Proskuryakov
2005-12-04 06:25:16 PST
Actually, ICU supports the "cp1251" alias, and it's WebCore that blocks its usage in KWQCFStringEncodingFromIANACharsetName(). Created attachment 5028 [details]
proposed fix
If a charset name is not known, try to normalize it using ICU.
Admittedly, this is a band-aid fix, and the way to go is probably to get rid of
CFStringEncoding-related functions throughout WebKit, so that
KWQCFStringEncodingFromIANACharsetName() wouldn't be needed at all.
Created attachment 5029 [details]
proposed fix
Oops, no need to do the lookup again if the first attempt was successful.
Created attachment 5030 [details] proposed fix Fixed paths for non-existing files (see bug 5846). Comment on attachment 5030 [details]
proposed fix
If we're going to use the ICU aliases, then I would like to see all the
redundant entries in our encoding table removed.
Comment on attachment 5030 [details]
proposed fix
Seems fine to make this change. Would have liked to have a comment explaining
why the code is doing what it's doing.
|