Bug 59318 – [GTK] Initial tooltips implementation for WebKit2

• Component: WebKit2
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

Initial tooltips implementation for WebKit2

[Carlos Garcia Campos]

Created attachment 90911 [details]
Patch

It can be tested with both MiniBrowser and GtkLauncher (you need patch attached to bug #57820).

[Martin Robinson]

Comment on attachment 90911 [details]
Patch

Going to remove the review flag here until we can resolve API discussions.

[Carlos Garcia Campos]

Created attachment 95334 [details]
Patch updated to current git master

[Martin Robinson]

Comment on attachment 95334 [details]
Patch updated to current git master

View in context: https://bugs.webkit.org/attachment.cgi?id=95334&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:295
> +    if (keyboardMode) {
> +        notImplemented();
> +        return FALSE;
> +    }

This is for tooltips triggered by keyboard events, right? Is there a bug for this? If so it's probably best to leave the bug link in a comment.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:361
> +    if (tooltip && *tooltip != '\0') {

I think it's clearer to use tooltip[0] here.

[Carlos Garcia Campos]

Committed r87689: <http://trac.webkit.org/changeset/87689>