Bug 59284

Summary:

[V8] Nodes in shadow DOM should not be GCed while their hosts are alive

Product:

WebKit

Reporter:

Dominic Cooney <dominicc>

Component:

DOM

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, morrita

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

52962

Attachments:

Description	Flags
Patch	none

Description Dominic Cooney 2011-04-23 15:28:58 PDT

The lifetime of nodes in shadow DOM and their hosts should be linked, since event listeners and JavaScript properties set up on one should not disappear (via the wrapper being prematurely garbage collected) while the other is alive.

Comment 1 Dominic Cooney 2011-04-23 15:53:50 PDT

Created attachment 90863 [details]
Patch

Comment 2 Dimitri Glazkov (Google) 2011-04-23 16:35:12 PDT

Comment on attachment 90863 [details]
Patch

awesome!

Comment 3 Hajime Morrita 2011-04-23 18:31:29 PDT

Comment on attachment 90863 [details]
Patch

Clearing flags on attachment: 90863

Committed r84749: <http://trac.webkit.org/changeset/84749>

Comment 4 Hajime Morrita 2011-04-23 18:31:33 PDT

All reviewed patches have been landed.  Closing bug.