Bug 59283

Summary: wrong exception raised in Lighttpd start method
Product: WebKit Reporter: arno. <a.renevier>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
patch v1
none
patch v1
ojan: review+
patch v1.1 none

arno.
Reported 2011-04-23 14:04:52 PDT
Hi, when try to run the tests with lighttd server, for some reason server could not start. Then I get following exception: NameError: global name 'google' is not defined Actually, in start method of Lighttpd class, > raise google.httpd_utils.HttpdNotStarted('Failed to start httpd.') raises a name error because google is not defined. This does not change much, as an exception is raised anyway. But may be it's better to raise a relevant exception.
Attachments
patch v1 (1.33 KB, patch)
2011-04-23 14:11 PDT, arno. 		no flags
DetailsFormatted DiffDiff
patch v1 (1.61 KB, patch)
2011-04-23 14:16 PDT, arno. 		ojan: review+
DetailsFormatted DiffDiff
patch v1.1 (1.98 KB, patch)
2011-04-27 00:41 PDT, arno. 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
arno.
Comment 1 2011-04-23 14:11:23 PDT
Created attachment 90857 [details] patch v1
arno.
Comment 2 2011-04-23 14:16:04 PDT
Created attachment 90858 [details] patch v1 As HttpdNotStarted is not used anywhere else, it's also possible to remove it totally, and raise a simple Exception as in pache_http_server.py
Ojan Vafai
Comment 3 2011-04-26 16:23:32 PDT
Comment on attachment 90858 [details] patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=90858&action=review > Tools/ChangeLog:7 > + Would be nice to put a bit more detail here that google.httpd_utils.HttpdNotStarted does not exist.
arno.
Comment 4 2011-04-27 00:41:55 PDT
Created attachment 91247 [details] patch v1.1
WebKit Commit Bot
Comment 5 2011-05-01 18:03:25 PDT
Comment on attachment 91247 [details] patch v1.1 Clearing flags on attachment: 91247 Committed r85447: <http://trac.webkit.org/changeset/85447>
WebKit Commit Bot
Comment 6 2011-05-01 18:03:30 PDT
All reviewed patches have been landed. Closing bug.
Eric Seidel (no email)
Comment 7 2011-05-01 18:27:26 PDT
Committed r85449: <http://trac.webkit.org/changeset/85449>
Note You need to log in before you can comment on or make changes to this bug.