Bug 59253

Summary:

CommitQueue should remember the expected failures from patch to patch

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	eric: review+

Description Adam Barth 2011-04-22 16:23:35 PDT

CommitQueue should remember the expected failures from patch to patch

Comment 1 Adam Barth 2011-04-22 16:24:49 PDT

Created attachment 90799 [details]
Patch

Comment 2 Eric Seidel (no email) 2011-04-22 16:27:18 PDT

Comment on attachment 90799 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90799&action=review

Otherwise looks fine.

> Tools/Scripts/webkitpy/tool/bot/patchanalysistask.py:69
> -        self._expected_failures = ExpectedFailures()
> +        self._expected_failures = delegate.expected_failures()

Looks like we should jus tpass them into the constructor instead.

Comment 3 Adam Barth 2011-04-22 16:35:49 PDT

Committed r84704: <http://trac.webkit.org/changeset/84704>