Bug 59248

Summary:

WebKit2: Implement JavaScript unresponsiveness timer/callbacks

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit-ews

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	bweinstein: review+

Description Sam Weinig 2011-04-22 15:28:16 PDT

WebKit2: Implement JavaScript unresponsiveness timer/callbacks

Comment 1 Sam Weinig 2011-04-22 15:34:44 PDT

Created attachment 90783 [details]
Patch

Comment 2 Early Warning System Bot 2011-04-22 16:18:46 PDT

Attachment 90783 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8495589

Comment 3 Brian Weinstein 2011-04-22 16:24:43 PDT

Comment on attachment 90783 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90783&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:1949
> +    // Since runJavaScriptPrompt() can spin a nested run loop we need to turn off the responsiveness timer.

Did you mean for this to be shouldInterruptJavaScript?

Comment 4 Jeff Miller 2011-04-22 16:25:29 PDT

Comment on attachment 90783 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90783&action=review

> Source/WebKit2/UIProcess/API/qt/qwkpage.cpp:503
> +        0   /* saveDataToFileInDownloadsFolder */

Missing a comma here, which is what probably broke the Qt build.

Comment 5 Sam Weinig 2011-04-22 16:29:07 PDT

Committed r84702: <http://trac.webkit.org/changeset/84702>