Bug 59244

Summary: Factor LayoutTestResultsReader out of CommitQueue
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch eric: review+

Adam Barth
Reported 2011-04-22 15:09:54 PDT
Factor LayoutTestResultsReader out of CommitQueue
Attachments
Patch (20.74 KB, patch)
2011-04-22 15:10 PDT, Adam Barth 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-04-22 15:10:49 PDT
Created attachment 90774 [details] Patch
Eric Seidel (no email)
Comment 2 2011-04-22 15:13:18 PDT
Comment on attachment 90774 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90774&action=review > Tools/Scripts/webkitpy/tool/bot/layouttestresultsreader.py:39 > + self._log_directory = log_directory I would name this archive_directory or something. > Tools/Scripts/webkitpy/tool/bot/layouttestresultsreader.py:55 > + return LayoutTestResults.results_from_string(results_html) Heads up: Ojan is about to break this call into two calls. One for ORWT and one for NRWT. > Tools/Scripts/webkitpy/tool/bot/layouttestresultsreader.py:64 > + results.set_failure_limit_count(RunTests.NON_INTERACTIVE_FAILURE_LIMIT_COUNT) Heads up: this is going to be wrong for NWRT.
Adam Barth
Comment 3 2011-04-22 15:17:34 PDT
Committed r84689: <http://trac.webkit.org/changeset/84689>
WebKit Review Bot
Comment 4 2011-04-22 16:04:15 PDT
http://trac.webkit.org/changeset/84689 might have broken SnowLeopard Intel Release (Build)
Note You need to log in before you can comment on or make changes to this bug.