Bug 59224

Summary: Don't rely on hasSpinButton to check if an input type can be stepped
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: FormsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, joepeck, simon.fraser, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
[PATCH] Proposed Fix - Add isSteppable tkent: review+

Joseph Pecoraro
Reported 2011-04-22 13:01:06 PDT
Add isSteppable. This almost removes the last usage of isRangeControl, but it is used once later on in the function. We shouldn't assert that a steppable control has a spinner, since a spinner is a UI detail and steppability is functionality.
Attachments
[PATCH] Proposed Fix - Add isSteppable (7.10 KB, patch)
2011-04-22 13:10 PDT, Joseph Pecoraro 		tkent: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2011-04-22 13:10:35 PDT
Created attachment 90746 [details] [PATCH] Proposed Fix - Add isSteppable
Kent Tamura
Comment 2 2011-04-22 13:35:34 PDT
Comment on attachment 90746 [details] [PATCH] Proposed Fix - Add isSteppable ok
Joseph Pecoraro
Comment 3 2011-04-22 14:33:28 PDT
Landed in <http://trac.webkit.org/changeset/84683>.
Joseph Pecoraro
Comment 4 2011-04-22 14:37:57 PDT
Arg, I should also have removed the now unused HTMLInputElement::hasSpinButton. I'll be working on a follow-up patch that will do that soon.
WebKit Review Bot
Comment 5 2011-04-22 16:19:01 PDT
http://trac.webkit.org/changeset/84683 might have broken GTK Linux 64-bit Debug
Note You need to log in before you can comment on or make changes to this bug.