|Summary:||Don't rely on hasSpinButton to check if an input type can be stepped|
|Product:||WebKit||Reporter:||Joseph Pecoraro <joepeck>|
|Severity:||Normal||CC:||abarth, eric, joepeck, simon.fraser, tkent, webkit.review.bot|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
Description Joseph Pecoraro 2011-04-22 13:01:06 PDT
Add isSteppable. This almost removes the last usage of isRangeControl, but it is used once later on in the function. We shouldn't assert that a steppable control has a spinner, since a spinner is a UI detail and steppability is functionality.
Comment 1 Joseph Pecoraro 2011-04-22 13:10:35 PDT
Created attachment 90746 [details] [PATCH] Proposed Fix - Add isSteppable
Comment 2 Kent Tamura 2011-04-22 13:35:34 PDT
Comment on attachment 90746 [details] [PATCH] Proposed Fix - Add isSteppable ok
Comment 3 Joseph Pecoraro 2011-04-22 14:33:28 PDT
Landed in <http://trac.webkit.org/changeset/84683>.
Comment 4 Joseph Pecoraro 2011-04-22 14:37:57 PDT
Arg, I should also have removed the now unused HTMLInputElement::hasSpinButton. I'll be working on a follow-up patch that will do that soon.