Bug 59216
| Summary: | Sheriffbot should be taught about contributors | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | abarth, ap, levin |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
| Bug Depends on: | 59209 | ||
| Bug Blocks: | |||
Eric Seidel (no email)
Sheriffbot should be taught about contributors
In bug 59209, support for contributors who are not committers was added.
We need to add new functions "contributor_by_email" and "contributor_by_name" to committers.py
and change this one callsite:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py#L67
And then the sheriffbot will be able to notify contributors over IRC.
I suspect we'll want to audit all other uses of committer_by_email as well.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
I think it got changed already?
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py#L108