| Summary: | Bugzilla autocomplete should support frequent contributors who are not committers | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||||
| Component: | Tools / Tests | Assignee: | Alexey Proskuryakov <ap> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Enhancement | CC: | abarth, levin, ojan, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 59216 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Alexey Proskuryakov
2011-04-22 10:19:14 PDT
Created attachment 90718 [details]
proposed patch
Attachment 90718 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/Scripts/webkitpy/common/config/commi..." exit_code: 1 Traceback (most recent call last): File "Tools/Scripts/check-webkit-style", line 51, in <module> from webkitpy.style_references import detect_checkout File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style_references.py", line 48, in <module> from webkitpy.layout_tests import port File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/layout_tests/port/__init__.py", line 34, in <module> from test import unit_test_filesystem File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/layout_tests/port/test.py", line 37, in <module> from webkitpy.tool import mocktool File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/tool/mocktool.py", line 32, in <module> from webkitpy.common.config.committers import CommitterList, Reviewer File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 65, in <module> Contributor("Anne van Kesteren", "annevankesteren+webkit@gmail.com", "annevk"), NameError: name 'Contributor' is not defined If any of these errors are false positives, please file a bug against check-webkit-style. Created attachment 90719 [details]
updated patch
Indeed, should define the class, even though the contributor list is unused...
Created attachment 90720 [details]
ick
Comment on attachment 90720 [details]
ick
I've wanted this many times too. Thanks for adding it.
Dave, I'm not sure, but this my affect your Chrome extension. Committed (with one more Python compilation fix) in <http://trac.webkit.org/changeset/84645>. Fingers crossed. (In reply to comment #6) > Dave, I'm not sure, but this my affect your Chrome extension. Thanks Ojan. This is cool! I don't think it will hurt it, but it will make a nice enhancement. I should try to open source that extension some time (or maybe ping folks again about permission to publish it). Comment on attachment 90720 [details] ick View in context: https://bugs.webkit.org/attachment.cgi?id=90720&action=review > Tools/Scripts/webkitpy/common/config/committers.py:36 > + This looks wrong? __init__ should actually do something with this data, no? Comment on attachment 90720 [details] ick View in context: https://bugs.webkit.org/attachment.cgi?id=90720&action=review >> Tools/Scripts/webkitpy/common/config/committers.py:36 >> + > > This looks wrong? __init__ should actually do something with this data, no? It shouldn't. But it needed an explicit return, which I added before committing. > It shouldn't. OK, it should in order to implement improvements like those suggested in bug 59216, but not for Bugzilla. |