Bug 59205

Summary: Make it harder to use HandleSlot incorrectly
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Severity: Normal CC: abarth, buildbot, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 59217, 59218    
Bug Blocks:    
Description Flags
Patch ggaren: review+

Description Oliver Hunt 2011-04-22 09:41:11 PDT
Make it harder to use HandleSlot incorrectly
Comment 1 Oliver Hunt 2011-04-22 11:03:36 PDT
Created attachment 90726 [details]
Comment 2 Geoffrey Garen 2011-04-22 11:17:18 PDT
Comment on attachment 90726 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=90726&action=review


> Source/JavaScriptCore/runtime/WriteBarrier.h:47
> +    JSValue* toJSValueRef() { return this; }

This name was a bit confusing to me because "JSValueRef" is a name in the JavaScriptCore API.

I'd recommend just having toJSValue(), and using &toJSValue() where needed.
Comment 3 Oliver Hunt 2011-04-22 11:28:20 PDT
Committed r84650: <http://trac.webkit.org/changeset/84650>
Comment 4 Build Bot 2011-04-22 11:29:20 PDT
Attachment 90726 [details] did not build on win:
Build output: http://queues.webkit.org/results/8498391
Comment 5 WebKit Review Bot 2011-04-22 11:47:45 PDT
http://trac.webkit.org/changeset/84650 might have broken Windows Release (Build) and Windows Debug (Build)