Bug 59205

Summary: Make it harder to use HandleSlot incorrectly
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, buildbot, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 59217, 59218    
Bug Blocks:    
Attachments:
Description Flags
Patch ggaren: review+

Oliver Hunt
Reported 2011-04-22 09:41:11 PDT
Make it harder to use HandleSlot incorrectly
Attachments
Patch (18.17 KB, patch)
2011-04-22 11:03 PDT, Oliver Hunt 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2011-04-22 11:03:36 PDT
Created attachment 90726 [details] Patch
Geoffrey Garen
Comment 2 2011-04-22 11:17:18 PDT
Comment on attachment 90726 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90726&action=review r=me > Source/JavaScriptCore/runtime/WriteBarrier.h:47 > + JSValue* toJSValueRef() { return this; } This name was a bit confusing to me because "JSValueRef" is a name in the JavaScriptCore API. I'd recommend just having toJSValue(), and using &toJSValue() where needed.
Oliver Hunt
Comment 3 2011-04-22 11:28:20 PDT
Committed r84650: <http://trac.webkit.org/changeset/84650>
Build Bot
Comment 4 2011-04-22 11:29:20 PDT
Attachment 90726 [details] did not build on win: Build output: http://queues.webkit.org/results/8498391
WebKit Review Bot
Comment 5 2011-04-22 11:47:45 PDT
http://trac.webkit.org/changeset/84650 might have broken Windows Release (Build) and Windows Debug (Build)
Note You need to log in before you can comment on or make changes to this bug.