Summary: | Make it harder to use HandleSlot incorrectly | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Oliver Hunt <oliver> | ||||
Component: | New Bugs | Assignee: | Oliver Hunt <oliver> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, buildbot, eric, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Bug Depends on: | 59217, 59218 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Oliver Hunt
2011-04-22 09:41:11 PDT
Created attachment 90726 [details]
Patch
Comment on attachment 90726 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90726&action=review r=me > Source/JavaScriptCore/runtime/WriteBarrier.h:47 > + JSValue* toJSValueRef() { return this; } This name was a bit confusing to me because "JSValueRef" is a name in the JavaScriptCore API. I'd recommend just having toJSValue(), and using &toJSValue() where needed. Committed r84650: <http://trac.webkit.org/changeset/84650> Attachment 90726 [details] did not build on win: Build output: http://queues.webkit.org/results/8498391 http://trac.webkit.org/changeset/84650 might have broken Windows Release (Build) and Windows Debug (Build) |