Bug 59191

Summary:

Web Inspector: js formatter should never insert new tokens or remove existing tokens and comments.

Product:

WebKit

Reporter:

Pavel Podivilov <podivilov>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Podivilov <podivilov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, apavlov, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
New JavaScript formatter based on UglifyJS tokenizer.	pfeldman: review+

Pavel Podivilov

Reported 2011-04-22 04:56:45 PDT

Web Inspector: js formatter should never insert new tokens or remove existing tokens and comments.

Attachments
New JavaScript formatter based on UglifyJS tokenizer. (104.79 KB, patch) 2011-04-22 05:03 PDT, Pavel Podivilov	pfeldman: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Pavel Podivilov

Comment 1 2011-04-22 05:03:26 PDT

Created attachment 90693 [details] New JavaScript formatter based on UglifyJS tokenizer.

Pavel Feldman

Comment 2 2011-04-22 05:24:07 PDT

Comment on attachment 90693 [details] New JavaScript formatter based on UglifyJS tokenizer. View in context: https://bugs.webkit.org/attachment.cgi?id=90693&action=review > Source/WebCore/WebCore.vcproj/WebCore.vcproj:67476 > + RelativePath="..\inspector\front-end\UglifyJS\JavaScriptFormatter.js" Is this formatter a part of the Uglify package? If not, it should be stored outside the folder.

Pavel Podivilov

Comment 3 2011-04-22 05:35:41 PDT

Committed r84620: <http://trac.webkit.org/changeset/84620>

WebKit Review Bot

Comment 4 2011-04-22 06:46:03 PDT

http://trac.webkit.org/changeset/84620 might have broken GTK Linux 32-bit Release The following tests are not passing: media/controls-strict.html

Note You need to log in before you can comment on or make changes to this bug.