Summary: | Add more test coverage to fast/url | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Weber <chris> | ||||||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, commit-queue, eric, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | Windows 7 | ||||||||||
URL: | http://www.lookout.net | ||||||||||
Attachments: |
|
Thanks. This patch isn't quite formated the way we like. I'll reformat it for you. In the future, you can upload patches for review by running the following script: ./Tools/Script/webkit-patch upload (You can also supply the bug number if you want to upload your patch to an existing bug.) That script will generated a ChangeLog entry for you and ask you to fill it out with a description of your patch. The script will also take care of making sure the patch is based in the root directory of the repository. Created attachment 90624 [details]
Patch
Created attachment 90633 [details]
Patch
The commit-queue encountered the following flaky tests while processing attachment 90633 [details]: http/tests/xmlhttprequest/basic-auth.html bug 51613 (author: ap@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 90633 [details] Patch Clearing flags on attachment: 90633 Committed r84606: <http://trac.webkit.org/changeset/84606> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/84606 might have broken Qt Linux Release The following tests are not passing: fast/url/idna2003.html fast/url/idna2008.html fast/url/path.html |
Created attachment 90609 [details] A patch adding new test cases to the fast/url test suite Adam Barth asked the public IRI mailing list for more test cases in this suite. - Added new test cases for IDNA2003 - Added new test cases for IDNA2008 - Augmented test cases for port.js, host.js, and path.js