| Summary: | Start moving to a general visitor pattern for GC traversal | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Oliver Hunt <oliver> | ||||||
| Component: | New Bugs | Assignee: | Oliver Hunt <oliver> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, buildbot, eric, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
Oliver Hunt
2011-04-21 14:44:30 PDT
Created attachment 90608 [details]
Patch
Attachment 90608 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackObject..." exit_code: 1
Source/JavaScriptCore/runtime/SmallStrings.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 119 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 90611 [details]
Patch
Attachment 90611 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackObject..." exit_code: 1
Source/JavaScriptCore/runtime/SmallStrings.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 120 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 90608 [details] did not build on win: Build output: http://queues.webkit.org/results/8496149 Comment on attachment 90611 [details]
Patch
r=me
Committed r84556: <http://trac.webkit.org/changeset/84556> http://trac.webkit.org/changeset/84556 might have broken Leopard Intel Debug (Tests) |