Bug 59141

Summary:

Start moving to a general visitor pattern for GC traversal

Product:

WebKit

Reporter:

Oliver Hunt <oliver>

Component:

New Bugs

Assignee:

Oliver Hunt <oliver>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, buildbot, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	ggaren: review+

Oliver Hunt

Reported 2011-04-21 14:44:30 PDT

Start moving to a general visitor pattern for GC traversal

Attachments
Patch (156.78 KB, patch) 2011-04-21 14:53 PDT, Oliver Hunt	no flags	Details Formatted Diff Diff
Patch (158.10 KB, patch) 2011-04-21 15:02 PDT, Oliver Hunt	ggaren: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Oliver Hunt

Comment 1 2011-04-21 14:53:42 PDT

Created attachment 90608 [details] Patch

WebKit Review Bot

Comment 2 2011-04-21 14:55:45 PDT

Attachment 90608 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackObject..." exit_code: 1 Source/JavaScriptCore/runtime/SmallStrings.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 119 files If any of these errors are false positives, please file a bug against check-webkit-style.

Oliver Hunt

Comment 3 2011-04-21 15:02:26 PDT

Created attachment 90611 [details] Patch

WebKit Review Bot

Comment 4 2011-04-21 15:04:48 PDT

Attachment 90611 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackObject..." exit_code: 1 Source/JavaScriptCore/runtime/SmallStrings.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 120 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 5 2011-04-21 15:20:20 PDT

Attachment 90608 [details] did not build on win: Build output: http://queues.webkit.org/results/8496149

Geoffrey Garen

Comment 6 2011-04-21 16:04:05 PDT

Comment on attachment 90611 [details] Patch r=me

Oliver Hunt

Comment 7 2011-04-21 16:08:48 PDT

Committed r84556: <http://trac.webkit.org/changeset/84556>

WebKit Review Bot

Comment 8 2011-04-21 16:43:26 PDT

http://trac.webkit.org/changeset/84556 might have broken Leopard Intel Debug (Tests)

Note You need to log in before you can comment on or make changes to this bug.