Bug 59141 - Start moving to a general visitor pattern for GC traversal
Summary: Start moving to a general visitor pattern for GC traversal
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-21 14:44 PDT by Oliver Hunt
Modified: 2011-04-21 16:43 PDT (History)
4 users (show)

See Also:


Attachments
Patch (156.78 KB, patch)
2011-04-21 14:53 PDT, Oliver Hunt
no flags Details | Formatted Diff | Diff
Patch (158.10 KB, patch)
2011-04-21 15:02 PDT, Oliver Hunt
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2011-04-21 14:44:30 PDT
Start moving to a general visitor pattern for GC traversal
Comment 1 Oliver Hunt 2011-04-21 14:53:42 PDT
Created attachment 90608 [details]
Patch
Comment 2 WebKit Review Bot 2011-04-21 14:55:45 PDT
Attachment 90608 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackObject..." exit_code: 1

Source/JavaScriptCore/runtime/SmallStrings.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 119 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Oliver Hunt 2011-04-21 15:02:26 PDT
Created attachment 90611 [details]
Patch
Comment 4 WebKit Review Bot 2011-04-21 15:04:48 PDT
Attachment 90611 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackObject..." exit_code: 1

Source/JavaScriptCore/runtime/SmallStrings.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 120 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Build Bot 2011-04-21 15:20:20 PDT
Attachment 90608 [details] did not build on win:
Build output: http://queues.webkit.org/results/8496149
Comment 6 Geoffrey Garen 2011-04-21 16:04:05 PDT
Comment on attachment 90611 [details]
Patch

r=me
Comment 7 Oliver Hunt 2011-04-21 16:08:48 PDT
Committed r84556: <http://trac.webkit.org/changeset/84556>
Comment 8 WebKit Review Bot 2011-04-21 16:43:26 PDT
http://trac.webkit.org/changeset/84556 might have broken Leopard Intel Debug (Tests)