Summary: | WebKit is erroneously modifying the DOM; adding 'aria-selected' to tables | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | chris fleizach <cfleizach> | ||||
Component: | Accessibility | Assignee: | chris fleizach <cfleizach> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bdakin, webkit.review.bot | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
chris fleizach
2011-04-21 14:24:54 PDT
Created attachment 90641 [details]
patch
Attachment 90641 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/acce..." exit_code: 1
Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1639: Should only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2240: Should only a single space after a punctuation in a comment. [whitespace/comments] [5]
Total errors found: 2 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 90641 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=90641&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1641 > Is there any reason to leave this empty function around? It seems like we should just get rid of it. > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2242 > Same here. (In reply to comment #4) > (From update of attachment 90641 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=90641&action=review > > > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1641 > > > > Is there any reason to leave this empty function around? It seems like we should just get rid of it. > > > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2242 > > > > Same here. I think eventually we want to put something there, but agreed, for now we should just remove Comment on attachment 90641 [details]
patch
r=me, but I would prefer for those functions to be removed for now.
(In reply to comment #6) > (From update of attachment 90641 [details]) > r=me, but I would prefer for those functions to be removed for now. thanks. will remove |