Bug 59105

Summary: Web Inspector: fix calls to WebInspector.ObjectPropertiesSection constructor
Product: WebKit Reporter: Andrey Kosyakov <caseq>
Component: Web Inspector (Deprecated)Assignee: Andrey Kosyakov <caseq>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch pfeldman: review+

Description Andrey Kosyakov 2011-04-21 08:24:00 PDT 
Many calls to WebInspector.ObjectPropertiesSection() are missing one of the arguments (apparently, empty placeholder).
This results in "true" being shown for objects with no properties (i.e. in case when object's __proto__ === null).
Comment 1 Andrey Kosyakov 2011-04-21 09:05:18 PDT 
Created attachment 90544 [details]
patch
Comment 2 Pavel Feldman 2011-04-21 09:08:52 PDT 
Comment on attachment 90544 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90544&action=review

> Source/WebCore/inspector/front-end/ConsoleView.js:600
> +        elem.appendChild(new WebInspector.ObjectPropertiesSection(obj, obj.description, null, null, false).element);

Just trim the call site here and in all changes below.
Comment 3 Andrey Kosyakov 2011-04-21 09:57:27 PDT 
Manually committed r84510: http://trac.webkit.org/changeset/84510