Bug 59091

Summary: [EFL] Remove ewk_eapi.h
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, gyuyoung.kim, kenneth, leandro, lucas.de.marchi, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Ryuan Choi
Reported 2011-04-21 05:58:40 PDT
IMO, ewk_eapi.h is just for EAPI macro provided by Eina.
Attachments
Patch (6.87 KB, patch)
2011-04-21 06:03 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2011-04-21 06:03:03 PDT
Created attachment 90518 [details] Patch
Gyuyoung Kim
Comment 2 2011-04-21 17:16:05 PDT
LGTM. BTW, if we want to change EAPI visibility, how to change it ? And also, if we want to define additional macro to adjust ewk files, is it good to keep the file ?
Ryuan Choi
Comment 3 2011-04-21 18:19:14 PDT
(In reply to comment #2) > LGTM. BTW, if we want to change EAPI visibility, how to change it ? And also, if we want to define additional macro to adjust ewk files, is it good to keep the file ? Does we need to change visibility? Although we need, it will not work well because Eina.h will redefine EAPI. About other macro, we can make better one at that time if needed. ewk_eapi.h looks just for eapi.
Gyuyoung Kim
Comment 4 2011-04-21 18:39:33 PDT
(In reply to comment #3) > (In reply to comment #2) > > LGTM. BTW, if we want to change EAPI visibility, how to change it ? And also, if we want to define additional macro to adjust ewk files, is it good to keep the file ? > > Does we need to change visibility? > Although we need, it will not work well because Eina.h will redefine EAPI. > > About other macro, > we can make better one at that time if needed. > ewk_eapi.h looks just for eapi. OK, LGTM.
WebKit Commit Bot
Comment 5 2011-04-25 04:18:15 PDT
Comment on attachment 90518 [details] Patch Clearing flags on attachment: 90518 Committed r84771: <http://trac.webkit.org/changeset/84771>
WebKit Commit Bot
Comment 6 2011-04-25 04:18:20 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 7 2011-04-25 11:07:16 PDT
http://trac.webkit.org/changeset/84771 might have broken SnowLeopard Intel Release (WebKit2 Tests)
Note You need to log in before you can comment on or make changes to this bug.