| Summary: | [EFL] Remove ewk_eapi.h | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryuan Choi <ryuan.choi> | ||||
| Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, commit-queue, eric, gyuyoung.kim, kenneth, leandro, lucas.de.marchi, tonikitoo, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Ryuan Choi
2011-04-21 05:58:40 PDT
Created attachment 90518 [details]
Patch
LGTM. BTW, if we want to change EAPI visibility, how to change it ? And also, if we want to define additional macro to adjust ewk files, is it good to keep the file ? (In reply to comment #2) > LGTM. BTW, if we want to change EAPI visibility, how to change it ? And also, if we want to define additional macro to adjust ewk files, is it good to keep the file ? Does we need to change visibility? Although we need, it will not work well because Eina.h will redefine EAPI. About other macro, we can make better one at that time if needed. ewk_eapi.h looks just for eapi. (In reply to comment #3) > (In reply to comment #2) > > LGTM. BTW, if we want to change EAPI visibility, how to change it ? And also, if we want to define additional macro to adjust ewk files, is it good to keep the file ? > > Does we need to change visibility? > Although we need, it will not work well because Eina.h will redefine EAPI. > > About other macro, > we can make better one at that time if needed. > ewk_eapi.h looks just for eapi. OK, LGTM. Comment on attachment 90518 [details] Patch Clearing flags on attachment: 90518 Committed r84771: <http://trac.webkit.org/changeset/84771> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/84771 might have broken SnowLeopard Intel Release (WebKit2 Tests) |