Bug 59087

Summary: Centralize typedef unsigned short Glyph in Glyph.h
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: WebCore Misc.Assignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 59085    
Attachments:
Description Flags
Patch
none
Patch v2
none
Patch v3 krit: review+

Description Nikolas Zimmermann 2011-04-21 03:10:39 PDT 
Centralize typedef unsigned short Glyph in Glyph.h
Comment 1 Nikolas Zimmermann 2011-04-21 03:29:49 PDT 
Created attachment 90507 [details]
Patch
Comment 2 Nikolas Zimmermann 2011-04-21 03:49:03 PDT 
Created attachment 90508 [details]
Patch v2

Oops, the first patch got truncated.
Comment 3 WebKit Review Bot 2011-04-21 04:30:32 PDT 
Attachment 90507 [details] did not build on mac:
Build output: http://queues.webkit.org/results/8486418
Comment 4 Nikolas Zimmermann 2011-04-21 04:37:58 PDT 
Created attachment 90510 [details]
Patch v3

Set Glyph.h role to private -- accidently reverted this part of WebCore.xcodeproj, while splitting up my large master patch in smaller chunks.
Comment 5 WebKit Review Bot 2011-04-21 05:31:43 PDT 
Attachment 90508 [details] did not build on mac:
Build output: http://queues.webkit.org/results/8493125
Comment 6 Dirk Schulze 2011-04-21 06:06:50 PDT 
Comment on attachment 90510 [details]
Patch v3

A lot content for one patch ;-) r=me
Comment 7 Nikolas Zimmermann 2011-04-21 06:08:03 PDT 
Landed in r84489.