Bug 59080

Summary: Add FontItalics and FontSmallCaps enums to be used instead of boolean values.
Product: WebKit Reporter: Luke Macpherson <macpherson>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, dglazkov, eric, macpherson, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Description Luke Macpherson 2011-04-21 00:25:31 PDT 
Add FontItalics and FontSmallCaps enums to be used instead of boolean values.
Comment 1 Luke Macpherson 2011-04-21 00:28:49 PDT 
Created attachment 90501 [details]
Patch
Comment 2 WebKit Review Bot 2011-04-21 00:53:42 PDT 
Attachment 90501 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8494028
Comment 3 Eric Seidel (no email) 2011-04-21 01:59:54 PDT 
Comment on attachment 90501 [details]
Patch

I'm surprised there are no callers of italic() or smallCaps()?
Comment 4 Luke Macpherson 2011-04-21 16:48:13 PDT 
(In reply to comment #3)
> (From update of attachment 90501 [details])
> I'm surprised there are no callers of italic() or smallCaps()?

There are two cases:
1) the form if(x->italic()), which has the same behavior since the *Off enum values are defined to be zero.
2) the form x->setItalic(y->italic), which is also covered by this CL.
Comment 5 Luke Macpherson 2011-04-21 17:39:47 PDT 
Created attachment 90642 [details]
Patch
Comment 6 WebKit Commit Bot 2011-04-22 00:40:48 PDT 
Comment on attachment 90642 [details]
Patch

Clearing flags on attachment: 90642

Committed r84609: <http://trac.webkit.org/changeset/84609>
Comment 7 WebKit Commit Bot 2011-04-22 00:40:53 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 WebKit Review Bot 2011-04-22 01:45:54 PDT 
http://trac.webkit.org/changeset/84609 might have broken WinCairo Debug (Build)