Summary: | remove unneeded function from graphicscontext3d.cpp | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jon Lee <jonlee> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, jamesr, kbr, mjs | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Bug Depends on: | 59029 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Jon Lee
2011-04-20 22:37:37 PDT
Created attachment 90496 [details]
Patch
Comment on attachment 90496 [details]
Patch
r=me
I can't really tell what is up with that function, it may be that it was meant to be used, but the relevant case block of doPacking was just overlooked when converting. But removing it seems like a safe fix for now. If it was intended to be used, the folks who came up with the change can handle it.
Comment on attachment 90496 [details] Patch Clearing flags on attachment: 90496 Committed r84474: <http://trac.webkit.org/changeset/84474> All reviewed patches have been landed. Closing bug. The commit-queue encountered the following flaky tests while processing attachment 90496 [details]: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) The commit-queue is continuing to process your patch. Thanks for the cleanup. I didn't see this issue locally. |