Bug 59076

Summary: remove unneeded function from graphicscontext3d.cpp
Product: WebKit Reporter: Jon Lee <jonlee>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jamesr, kbr, mjs
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 59029    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Jon Lee 2011-04-20 22:37:37 PDT
refactoring from http://trac.webkit.org/changeset/84441 leaves a compile warning, that unpackOneRowOfRGBA8ToRGBA8 is unused.
Comment 1 Jon Lee 2011-04-20 22:48:25 PDT
<rdar://problem/9315681>
Comment 2 Jon Lee 2011-04-20 22:48:56 PDT
Created attachment 90496 [details]
Patch
Comment 3 Maciej Stachowiak 2011-04-20 22:54:51 PDT
Comment on attachment 90496 [details]
Patch

r=me

I can't really tell what is up with that function, it may be that it was meant to be used, but the relevant case block of doPacking was just overlooked when converting. But removing it seems like a safe fix for now. If it was intended to be used, the folks who came up with the change can handle it.
Comment 4 WebKit Commit Bot 2011-04-21 00:25:13 PDT
Comment on attachment 90496 [details]
Patch

Clearing flags on attachment: 90496

Committed r84474: <http://trac.webkit.org/changeset/84474>
Comment 5 WebKit Commit Bot 2011-04-21 00:25:18 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Commit Bot 2011-04-21 00:41:33 PDT
The commit-queue encountered the following flaky tests while processing attachment 90496 [details]:

http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com)
The commit-queue is continuing to process your patch.
Comment 7 Kenneth Russell 2011-04-21 10:35:18 PDT
Thanks for the cleanup. I didn't see this issue locally.