Bug 59060

Summary: Remove redundant calls to RenderStyle::setDisplay()
Product: WebKit Reporter: Luke Macpherson <macpherson>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, eric, macpherson, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Description Luke Macpherson 2011-04-20 18:53:07 PDT
Remove redundant calls to RenderStyle::setDisplay()
Comment 1 Luke Macpherson 2011-04-20 20:25:19 PDT
Created attachment 90482 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-04-20 20:33:19 PDT
Comment on attachment 90482 [details]
Patch

Why is the other setDisplay call not neccessary?
Comment 3 Luke Macpherson 2011-04-20 20:41:25 PDT
(In reply to comment #2)
> (From update of attachment 90482 [details])
> Why is the other setDisplay call not neccessary?

The HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE(display, Display) macro results in setDisplay(*primitiveValue).

This is what makes the other subsequent identical calls in else cases redundant.
Comment 4 WebKit Commit Bot 2011-04-21 23:14:04 PDT
Comment on attachment 90482 [details]
Patch

Clearing flags on attachment: 90482

Committed r84603: <http://trac.webkit.org/changeset/84603>
Comment 5 WebKit Commit Bot 2011-04-21 23:14:08 PDT
All reviewed patches have been landed.  Closing bug.