Summary: | [Qt] REGRESSION (r81479): build-webkit warning Inspector.idl is missing | ||
---|---|---|---|
Product: | WebKit | Reporter: | Rafael Brandao <rafael.lobo> |
Component: | WebKit Qt | Assignee: | Rafael Brandao <rafael.lobo> |
Status: | RESOLVED FIXED | ||
Severity: | Minor | CC: | abecsi, cmarcelo, commit-queue, ossy |
Priority: | P5 | Keywords: | Qt, QtTriaged |
Version: | 528+ (Nightly build) | ||
Hardware: | PC | ||
OS: | Linux | ||
Attachments: |
Description
Rafael Brandao
2011-04-20 17:17:29 PDT
The patch that caused this regression adds a generator and it should generate Inspector.idl before anything needs it. If you change the line that contains "inspectorIDL.input = INSPECTOR_IDL" to "inspectorIDL.input = $${WC_GENERATED_SOURCES_DIR}/Inspector.idl" on Source/WebCore/CodeGenerators.pri, the warning disappear. The problem is the build will not succeed in this case. For some yet unknown reason, the file "InspectorFrontend.h" is not generated, but necessary to "InspectorDebuggerAgent.h". Nevermind, I've figured out that when you create a qmake target, the input value expects a variable that contains the files that should be processed, so changing it to the files itself makes it stop working, that's why the warning was not showing up, and that also explains why the files did not generate after all. Created attachment 91759 [details] Added variable_out to pipe output from one compiler to another and then forced the output to be added to the sources. It was necessary to use variable_out to disable the annoying warning (http://bugreports.qt.nokia.com/browse/QTBUG-18938). As that variable should be added as input of the other generator, and this generator was used first in WebCore/DerivedSources.pro and then later at WebKit/qt/QtWebKit.pro, there was an issue with the input value, as it wasn't set at the later moment, and that would make the output to not be added to the sources. So I've made use of this already existing attribute called "wkExtraSources" to make sure that, in this special case, the output would be added anyway. Created attachment 91763 [details] Added variable_out to pipe output from one compiler to another and then forced the output to be added to the sources. It was necessary to use variable_out to disable the annoying warning (http://bugreports.qt.nokia.com/browse/QTBUG-18938). As that variable should be added as input of the other generator, and this generator was used first in WebCore/DerivedSources.pro and then later at WebKit/qt/QtWebKit.pro, there was an issue with the input value, as it wasn't set at the later moment, and that would make the output to not be added to the sources. So I've made use of this already existing attribute called "wkExtraSources" to make sure that, in this special case, the output would be added anyway. Comment on attachment 91763 [details]
Added variable_out to pipe output from one compiler to another and then forced the output to be added to the sources.
LGTM, though I'm not a reviewer.
Thanks for fixing this.
Comment on attachment 91763 [details]
Added variable_out to pipe output from one compiler to another and then forced the output to be added to the sources.
Great fix, r=me.
Comment on attachment 91763 [details] Added variable_out to pipe output from one compiler to another and then forced the output to be added to the sources. Clearing flags on attachment: 91763 Committed r85412: <http://trac.webkit.org/changeset/85412> All reviewed patches have been landed. Closing bug. |