| Summary: | Check for null m_context in WebGLLayerChromium and add resetting platform layer's context in the destructor of GraphicsContext3D. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Marinichev <amarinichev> | ||||||||
| Component: | New Bugs | Assignee: | Alexey Marinichev <amarinichev> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, kbr | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Other | ||||||||||
| OS: | OS X 10.5 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Alexey Marinichev
2011-04-20 17:17:18 PDT
Created attachment 90454 [details]
Patch
This is to avoid dereferencing stale pointer when recovering from lost context. Comment on attachment 90454 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90454&action=review The code change looks good. We've talked offline about the fact that it's only feasible to test this in an automated fashion with a Chromium browser test, which is being worked on. Unfortunately there's a problem with the ChangeLog that needs to be fixed. > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) The commit queue will reject this patch because of the presence of this line. You'll need to update it with information about the testing status. Created attachment 90460 [details]
Patch
Created attachment 90462 [details]
Patch
Comment on attachment 90462 [details]
Patch
Looks good. r=me
Comment on attachment 90462 [details] Patch Clearing flags on attachment: 90462 Committed r84449: <http://trac.webkit.org/changeset/84449> All reviewed patches have been landed. Closing bug. |