Bug 59045

Summary: Check for null m_context in WebGLLayerChromium and add resetting platform layer's context in the destructor of GraphicsContext3D.
Product: WebKit Reporter: Alexey Marinichev <amarinichev>
Component: New BugsAssignee: Alexey Marinichev <amarinichev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kbr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alexey Marinichev
Reported 2011-04-20 17:17:18 PDT
Check for null m_context in WebGLLayerChromium and add resetting platform layer's context in the destructor of GraphicsContext3D.
Attachments
Patch (4.37 KB, patch)
2011-04-20 17:20 PDT, Alexey Marinichev 		no flags
DetailsFormatted DiffDiff
Patch (4.37 KB, patch)
2011-04-20 17:53 PDT, Alexey Marinichev 		no flags
DetailsFormatted DiffDiff
Patch (4.52 KB, patch)
2011-04-20 18:00 PDT, Alexey Marinichev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alexey Marinichev
Comment 1 2011-04-20 17:20:33 PDT
Created attachment 90454 [details] Patch
Alexey Marinichev
Comment 2 2011-04-20 17:23:13 PDT
This is to avoid dereferencing stale pointer when recovering from lost context.
Kenneth Russell
Comment 3 2011-04-20 17:37:31 PDT
Comment on attachment 90454 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90454&action=review The code change looks good. We've talked offline about the fact that it's only feasible to test this in an automated fashion with a Chromium browser test, which is being worked on. Unfortunately there's a problem with the ChangeLog that needs to be fixed. > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) The commit queue will reject this patch because of the presence of this line. You'll need to update it with information about the testing status.
Alexey Marinichev
Comment 4 2011-04-20 17:53:19 PDT
Created attachment 90460 [details] Patch
Alexey Marinichev
Comment 5 2011-04-20 18:00:05 PDT
Created attachment 90462 [details] Patch
Kenneth Russell
Comment 6 2011-04-20 18:09:48 PDT
Comment on attachment 90462 [details] Patch Looks good. r=me
WebKit Commit Bot
Comment 7 2011-04-20 18:38:27 PDT
Comment on attachment 90462 [details] Patch Clearing flags on attachment: 90462 Committed r84449: <http://trac.webkit.org/changeset/84449>
WebKit Commit Bot
Comment 8 2011-04-20 18:38:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.