Bug 59032

Summary: [Mac]Regression: extending word that is already marked misspelled doesn't remove misspelling underline.
Product: WebKit Reporter: Jia Pu <jiapu.mail>
Component: New BugsAssignee: Jia Pu <jiapu.mail>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ddavidso
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.6   
Attachments:
Description Flags
Patch (v1) none

Description Jia Pu 2011-04-20 16:18:15 PDT
If the word "brough" is already marked as misspelled, appending "t" at the end doesn't remove the misspelling marker. 

This is a regression introduced in changeset 83344. In Editor.cpp, "removeSpellAndCorrectionMarkersFromWordsToBeEdited(isSpaceOrNewline(text[0])); " is replaced "updateMarkersForWordsAffectedByEditing(text[0]);", and the the call to isSpaceOrNewline() is missing.
Comment 1 Jia Pu 2011-04-20 17:03:16 PDT
<rdar://problem/9312444>
Comment 2 Jia Pu 2011-04-20 17:16:48 PDT
Created attachment 90452 [details]
Patch (v1)
Comment 3 Maciej Stachowiak 2011-04-20 17:32:59 PDT
Comment on attachment 90452 [details]
Patch (v1)

r=me
Comment 4 WebKit Commit Bot 2011-04-20 18:26:29 PDT
The commit-queue encountered the following flaky tests while processing attachment 90452 [details]:

animations/suspend-resume-animation.html bug 48161 (author: cmarrin@apple.com)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2011-04-20 18:28:46 PDT
Comment on attachment 90452 [details]
Patch (v1)

Clearing flags on attachment: 90452

Committed r84448: <http://trac.webkit.org/changeset/84448>
Comment 6 WebKit Commit Bot 2011-04-20 18:28:51 PDT
All reviewed patches have been landed.  Closing bug.