| Summary: | initial set of tests for new results.html file | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ojan Vafai <ojan> | ||||||
| Component: | New Bugs | Assignee: | Ojan Vafai <ojan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dpranke, eric, tony | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
Ojan Vafai
2011-04-20 16:10:16 PDT
Created attachment 90433 [details]
Patch
Comment on attachment 90433 [details]
Patch
How does one run the tests?
Created attachment 90439 [details]
Patch
You load json_results.html in a browser. Added comments to the top of json_results_test.js explaining this. Comment on attachment 90439 [details]
Patch
I see, so json_results.html is the template off of which results.html is based? I'm confused.
(In reply to comment #5) > (From update of attachment 90439 [details]) > I see, so json_results.html is the template off of which results.html is based? I'm confused. It just gets renamed in the copy. Eventually, I'll rename it to results.html and rename this js file to results_test.html. Comment on attachment 90439 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90439&action=review Ojan and I discussed moving this into LayoutTests/fast/harness so it'll be run automatically (in a follow up patch). > Tools/Scripts/webkitpy/layout_tests/layout_package/json_results.html:589 > +<script src="json_results_test.js"></script> Nit: Please add a comment explaining why this doesn't run when the user is viewing results.html. Committed r84514: <http://trac.webkit.org/changeset/84514> |