Bug 59014

Summary: Support DataView in workers
Product: WebKit Reporter: Jian Li <jianli>
Component: WebCore JavaScriptAssignee: Jian Li <jianli>
Status: RESOLVED FIXED    
Severity: Normal CC: kbr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Proposed Patch kbr: review+, jianli: commit-queue-

Jian Li
Reported 2011-04-20 11:56:40 PDT
We need to add support for DataView in workers.
Attachments
Proposed Patch (3.49 KB, patch)
2011-04-20 11:58 PDT, Jian Li 		kbr: review+
jianli: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jian Li
Comment 1 2011-04-20 11:58:24 PDT
Created attachment 90376 [details] Proposed Patch
Kenneth Russell
Comment 2 2011-04-20 13:37:00 PDT
Comment on attachment 90376 [details] Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90376&action=review Looks good. One minor comment about the test. > LayoutTests/fast/canvas/webgl/resources/worker-data-view-test.js:2 > + var array = new Uint8Array(4); It would be safer to write this as "new Uint32Array(1)".
Jian Li
Comment 3 2011-04-20 14:38:50 PDT
Committed as https://trac.webkit.org/changeset/84418.
Note You need to log in before you can comment on or make changes to this bug.