Bug 59014

Summary: Support DataView in workers
Product: WebKit Reporter: Jian Li <jianli>
Component: WebCore JavaScriptAssignee: Jian Li <jianli>
Status: RESOLVED FIXED    
Severity: Normal CC: kbr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Proposed Patch kbr: review+, jianli: commit-queue-

Description Jian Li 2011-04-20 11:56:40 PDT 
We need to add support for DataView in workers.
Comment 1 Jian Li 2011-04-20 11:58:24 PDT 
Created attachment 90376 [details]
Proposed Patch
Comment 2 Kenneth Russell 2011-04-20 13:37:00 PDT 
Comment on attachment 90376 [details]
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90376&action=review

Looks good. One minor comment about the test.

> LayoutTests/fast/canvas/webgl/resources/worker-data-view-test.js:2
> +    var array = new Uint8Array(4);

It would be safer to write this as "new Uint32Array(1)".
Comment 3 Jian Li 2011-04-20 14:38:50 PDT 
Committed as https://trac.webkit.org/changeset/84418.