Bug 59012

Summary: Shadows should be imported along with their host nodes
Product: WebKit Reporter: Dominic Cooney <dominicc>
Component: DOMAssignee: Roland Steiner <rolandsteiner>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, rolandsteiner, tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 52962, 61909    
Attachments:
Description Flags
Patch none

Dominic Cooney
Reported 2011-04-20 11:43:39 PDT
Document::importedNode doesn’t import new-style shadows. This means that as nodes are imported, they lose their shadows.
Attachments
Patch (5.14 KB, patch)
2011-04-20 19:30 PDT, Roland Steiner 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dominic Cooney
Comment 1 2011-04-20 11:44:11 PDT
s/importedNode/importNode/
Roland Steiner
Comment 2 2011-04-20 19:30:18 PDT
Created attachment 90478 [details] Patch
Kent Tamura
Comment 3 2011-04-20 19:33:41 PDT
Comment on attachment 90478 [details] Patch Looks good
Kent Tamura
Comment 4 2011-04-20 19:51:36 PDT
BTW, what about Node::cloneNode()?
Roland Steiner
Comment 5 2011-04-21 09:59:09 PDT
(In reply to comment #4) > BTW, what about Node::cloneNode()? Both importNode() and cloneNode() call copyNonAttributeProperties for nodes they clone, so both are handled by this patch. But note that a direct call to cloneNode() and importNode() is currently forbidden. It the end it depends on the JS API we will have for shadowRoot, I think. If you can assign directly to element.shadowRoot, e.g., myBoundElement.shadowRoot = myOtherBoundElement.shadowRoot.cloneNode() then we will need to allow a direct call to cloneNode and importNode on a ShadowRoot.
WebKit Commit Bot
Comment 6 2011-04-21 11:32:31 PDT
Comment on attachment 90478 [details] Patch Clearing flags on attachment: 90478 Committed r84528: <http://trac.webkit.org/changeset/84528>
WebKit Commit Bot
Comment 7 2011-04-21 11:32:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.