Bug 59010

Summary: [chromium] expose title text direction on WebDataSource
Product: WebKit Reporter: Evan Martin <evan>
Component: New BugsAssignee: Evan Martin <evan>
Status: RESOLVED FIXED    
Severity: Normal CC: fishd
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch tony: review+

Evan Martin
Reported 2011-04-20 11:14:06 PDT
[chromium] expose text direction WebDataSource
Attachments
Patch (3.03 KB, patch)
2011-04-20 11:14 PDT, Evan Martin 		no flags
DetailsFormatted DiffDiff
Patch (3.10 KB, patch)
2011-04-20 11:17 PDT, Evan Martin 		tony: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Evan Martin
Comment 1 2011-04-20 11:14:51 PDT
Created attachment 90368 [details] Patch
Evan Martin
Comment 2 2011-04-20 11:17:42 PDT
Created attachment 90369 [details] Patch
Evan Martin
Comment 3 2011-04-20 11:54:23 PDT
Committed r84400: <http://trac.webkit.org/changeset/84400>
Darin Fisher (:fishd, Google)
Comment 4 2011-04-20 12:45:01 PDT
Comment on attachment 90369 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90369&action=review > Source/WebKit/chromium/src/WebDataSourceImpl.cpp:90 > + return title().direction() == LTR ? WebTextDirectionLeftToRight : WebTextDirectionRightToLeft; would it make sense for the WebKit API to have a WebStringWithDirection? maybe we will want to shuttle this information across the webkit API in other places in the future too?
Evan Martin
Comment 5 2011-04-20 13:30:14 PDT
Comment on attachment 90369 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90369&action=review >> Source/WebKit/chromium/src/WebDataSourceImpl.cpp:90 >> + return title().direction() == LTR ? WebTextDirectionLeftToRight : WebTextDirectionRightToLeft; > > would it make sense for the WebKit API to have a WebStringWithDirection? maybe we will want to shuttle this information across the webkit API in other places in the future too? I *believe* this and the didReceiveTitle are the only two, so I was hoping to keep it simple for now. Is it ok if I just keep this idea in mind for the future?
Darin Fisher (:fishd, Google)
Comment 6 2011-04-20 14:05:08 PDT
(In reply to comment #5) > I *believe* this and the didReceiveTitle are the only two, so I was hoping to keep it simple for now. Is it ok if I just keep this idea in mind for the future? Yes, that's probably OK. A quick grep of chromium/public/ suggests a couple other places where WebStringWithDirection might be useful: WebViewClient::setTooltipText WebNotification::{title,body,direction}
Note You need to log in before you can comment on or make changes to this bug.