Summary: | [chromium] expose title text direction on WebDataSource | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Evan Martin <evan> | ||||||
Component: | New Bugs | Assignee: | Evan Martin <evan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | fishd | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Evan Martin
2011-04-20 11:14:06 PDT
Created attachment 90368 [details]
Patch
Created attachment 90369 [details]
Patch
Committed r84400: <http://trac.webkit.org/changeset/84400> Comment on attachment 90369 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90369&action=review > Source/WebKit/chromium/src/WebDataSourceImpl.cpp:90 > + return title().direction() == LTR ? WebTextDirectionLeftToRight : WebTextDirectionRightToLeft; would it make sense for the WebKit API to have a WebStringWithDirection? maybe we will want to shuttle this information across the webkit API in other places in the future too? Comment on attachment 90369 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90369&action=review >> Source/WebKit/chromium/src/WebDataSourceImpl.cpp:90 >> + return title().direction() == LTR ? WebTextDirectionLeftToRight : WebTextDirectionRightToLeft; > > would it make sense for the WebKit API to have a WebStringWithDirection? maybe we will want to shuttle this information across the webkit API in other places in the future too? I *believe* this and the didReceiveTitle are the only two, so I was hoping to keep it simple for now. Is it ok if I just keep this idea in mind for the future? (In reply to comment #5) > I *believe* this and the didReceiveTitle are the only two, so I was hoping to keep it simple for now. Is it ok if I just keep this idea in mind for the future? Yes, that's probably OK. A quick grep of chromium/public/ suggests a couple other places where WebStringWithDirection might be useful: WebViewClient::setTooltipText WebNotification::{title,body,direction} |