Bug 59009

Summary: [Mac] Like autocorrection, other types of substitution need to respect undo.
Product: WebKit Reporter: Jia Pu <jiapu.mail>
Component: New BugsAssignee: Jia Pu <jiapu.mail>
Status: RESOLVED FIXED    
Severity: Normal CC: adele, commit-queue, ddavidso
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: OS X 10.6   
Attachments:
Description Flags
Patch
none
Patch (v2) none

Description Jia Pu 2011-04-20 10:50:17 PDT 
On Mac, when text substitution is turned on, (c) will get converted to © automatically. However, if user undid such substitution, then we shouldn't convert it again. This should also apply to automatically adding link to url string. 

<rdar://problem/8601537>
Comment 1 Jia Pu 2011-04-20 11:00:19 PDT 
Created attachment 90361 [details]
Patch
Comment 2 Adele Peterson 2011-04-20 14:30:24 PDT 
Comment on attachment 90361 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90361&action=review

> Source/WebCore/ChangeLog:9
> +        Similar to autocorreciton, we use SpellingCorrectionCommand to carry out other types of text substitution, so that

Typo - "autocorrection"
Comment 3 Jia Pu 2011-04-20 14:46:44 PDT 
Created attachment 90419 [details]
Patch (v2)
Comment 4 WebKit Commit Bot 2011-04-20 16:35:30 PDT 
Comment on attachment 90419 [details]
Patch (v2)

Clearing flags on attachment: 90419

Committed r84433: <http://trac.webkit.org/changeset/84433>
Comment 5 WebKit Commit Bot 2011-04-20 16:35:36 PDT 
All reviewed patches have been landed.  Closing bug.