| Summary: | [buildbot]Show more recent builds on builder page | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, aroben, commit-queue, eric, galpeter, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Csaba Osztrogonác
2011-04-20 10:44:24 PDT
(In reply to comment #0) > If I click on a builder on waterfall page, > I can see only 5 builds under the recent builds. > > It would be great if we can see more than 5 to make gardening more effective. > I know that I can add "?numbuilds=100" to the URL, but it isn't so user friendly. > Can't we add this option to master.cfg somehow? It is possible to pass 'numbuilds' argument to the WebStatus in the master.cfg, but that does not affects the builder's page. But we can override the build in template which will contain the required extra links. Created attachment 90362 [details]
template patch
Simply added these lines to the built-in template:
( Show: <a href="{{ builder_url }}">default</a>
{% for count in [25, 50, 100, 200] %}
<a href="{{ builder_url }}?numbuilds={{ count }}">{{ count }}</a>
{% endfor %})
This will show five links with different 'numbuilds' parameters.
Comment on attachment 90362 [details]
template patch
yay, shibbbyyyy!
r=me
Adam, could you run a reconfigure on the buildmaster after it is landed? BTW, this template is from Buildbot v0.8.3, so it should apply cleanly to the apple's buildmaster. It would be slightly clearer to check in the unmodified template first, and then customize it after that in a separate change. I can take care of updating the master after this lands. Comment on attachment 90362 [details]
template patch
OK, let's check in the unmodified template first, and then patch it.
Created attachment 90375 [details]
base template
This is the built-in template from buildbot v0.8.3.
The commit-queue encountered the following flaky tests while processing attachment 90362 [details]: http/tests/xmlhttprequest/logout.html bug 52047 (author: ap@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 90375 [details] base template Landed in http://trac.webkit.org/changeset/84421 Modifying the default template landed in http://trac.webkit.org/changeset/84423 http://trac.webkit.org/changeset/84423 might have broken Chromium Win Release (In reply to comment #11) > Modifying the default template landed in http://trac.webkit.org/changeset/84423 Cool, Thanks! |