Bug 59003

Summary:

Update fast/canvas/font-update.html to use dumpAsText

Product:

WebKit

Reporter:

Matthew Delaney <mdelaney7>

Component:

New Bugs

Assignee:

Matthew Delaney <mdelaney7>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	mitz: review+

Matthew Delaney

Reported 2011-04-20 09:39:14 PDT

Update fast/canvas/font-update.html to use dumpAsText

Attachments
Patch (1.75 KB, patch) 2011-04-20 09:40 PDT, Matthew Delaney	mitz: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Matthew Delaney

Comment 1 2011-04-20 09:40:09 PDT

Created attachment 90350 [details] Patch

Adam Roben (:aroben)

Comment 2 2011-04-20 09:42:48 PDT

Comment on attachment 90350 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90350&action=review > LayoutTests/ChangeLog:9 > + Reviewed by NOBODY (OOPS!). > + > + Update fast/canvas/font-update.html to use dumpAsText > + https://bugs.webkit.org/show_bug.cgi?id=59003 > + > + * fast/canvas/font-update-expected.txt: > + * fast/canvas/font-update.html: Your ChangeLog should explain why this is an OK thing to do. Explaining the purpose of the test will probably be part of that. (E.g., if the test is just detecting a crash, then dumpAsText is probably fine.)

Matthew Delaney

Comment 3 2011-04-20 10:07:02 PDT

Committed r84390: <http://trac.webkit.org/changeset/84390>

Note You need to log in before you can comment on or make changes to this bug.