Bug 58993

Summary: Web Inspector: persist local resource history between inspector / browser launches.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
[PATCH] With the loaderId check. none

Description Pavel Feldman 2011-04-20 08:21:22 PDT
Patch to follow.
Comment 1 Pavel Feldman 2011-04-20 08:28:04 PDT
Created attachment 90341 [details]
Patch
Comment 2 Yury Semikhatsky 2011-04-20 09:32:29 PDT
Comment on attachment 90341 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90341&action=review

> Source/WebCore/inspector/front-end/Resource.js:742
>          this._content = newContent;

This way the content displayed in the inspector will differ from the actual one after the restore.
Comment 3 Pavel Feldman 2011-04-20 11:06:10 PDT
Created attachment 90365 [details]
[PATCH] With the loaderId check.
Comment 4 Yury Semikhatsky 2011-04-21 04:25:02 PDT
Comment on attachment 90365 [details]
[PATCH] With the loaderId check.

View in context: https://bugs.webkit.org/attachment.cgi?id=90365&action=review

> Source/WebCore/inspector/front-end/ResourceTreeModel.js:306
>          resource.frameId = frame.id;

Consider passing all of these values as parameter to the constructor.
Comment 5 Pavel Feldman 2011-04-21 04:43:59 PDT
Comment on attachment 90365 [details]
[PATCH] With the loaderId check.

Clearing flags on attachment: 90365

Committed r84483: <http://trac.webkit.org/changeset/84483>
Comment 6 Pavel Feldman 2011-04-21 04:44:08 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Review Bot 2011-04-21 07:07:09 PDT
http://trac.webkit.org/changeset/84483 might have broken GTK Linux 32-bit Debug
The following tests are not passing:
media/controls-strict.html