Bug 58990 – REGRESSION (r84306-r84311?): editing/undo/undo-iframe-location-change.html sometimes fails on SnowLeopard Intel Release (WebKit2 Tests)

• Component: HTML Editing
• Status: NEW

[Jessie Berlin]

http://trac.webkit.org/changeset/84307

http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r84306%20(10865)/results.html
http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r84311%20(10866)/results.html

In addition, I am not really sure why the pixel test results for compositing/iframes/invisible-iframe.html and compositing/iframes/invisible-nested-iframe-hide.html are in the cross-platform directory. I would expect those tests to be failing when run with -p on a bunch of platforms.

[Ryosuke Niwa]

Enrica and I investigated the failure of editing/undo/undo-iframe-location-change.html but it passes locally.

[Jessie Berlin]

(In reply to comment #1)
> Enrica and I investigated the failure of editing/undo/undo-iframe-location-change.html but it passes locally.

Just to be sure, you tested with WK2? I ask because it is failing pretty consistently on the SL WK2 bots.

Did you get a chance to look into the compositing/iframes/invisible-nested-iframe-show.html failures?

[Enrica Casucci]

I just tested one more time with r84650 on my SnowLeopard machine and I see no failures in the editing tests.

[Ryosuke Niwa]

(In reply to comment #2)
> (In reply to comment #1)
> > Enrica and I investigated the failure of editing/undo/undo-iframe-location-change.html but it passes locally.
> 
> Just to be sure, you tested with WK2? I ask because it is failing pretty consistently on the SL WK2 bots.

Yes.

> Did you get a chance to look into the compositing/iframes/invisible-nested-iframe-show.html failures?

No.

[Jessie Berlin]

Because these are keeping the SL WK2 bots red, I am going to commit failing expected results soon.

[WebKit Review Bot]

http://trac.webkit.org/changeset/84783 might have broken Chromium Win Release

[Jessie Berlin]

Now I am really confused. As soon as I committed the expected failing results in http://trac.webkit.org/changeset/84783, the editing test started passing on the bots (which is now making the bots red again because it is expecting failure).

Any ideas as to what happened here?

[Adam Roben (:aroben)]

(In reply to comment #7)
> Now I am really confused. As soon as I committed the expected failing results in http://trac.webkit.org/changeset/84783, the editing test started passing on the bots (which is now making the bots red again because it is expecting failure).
> 
> Any ideas as to what happened here?

I guess the bots must have gone back to their previous behavior, because they aren't red anymore.

[Adam Roben (:aroben)]

These two tests seem unlikely to be failing for the same reason. I split out compositing/iframes/invisible-nested-iframe-show.html into a new bug: bug 59864.

[Adam Roben (:aroben)]

(In reply to comment #8)
> (In reply to comment #7)
> > Now I am really confused. As soon as I committed the expected failing results in http://trac.webkit.org/changeset/84783, the editing test started passing on the bots (which is now making the bots red again because it is expecting failure).
> > 
> > Any ideas as to what happened here?
> 
> I guess the bots must have gone back to their previous behavior, because they aren't red anymore.

My mistake, this test is indeed failing on the bots (because it's producing successful results, but we have failure results checked in).

I guess we should just remove the expected failure results and see if it starts failing again.

[Adam Roben (:aroben)]

Looks like this test is flaky:

http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28WebKit2%20Tests%29/builds/11238 did fail
http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28WebKit2%20Tests%29/builds/11237 did not fail
http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28WebKit2%20Tests%29/builds/11235 did fail

[Adam Roben (:aroben)]

Added to the mac-wk2 Skipped file in r85397.

[Adam Roben (:aroben)]

<rdar://problem/9363346>

[Ryosuke Niwa]

There might be some race condition going on here.  Maybe when a page navigates in WebProcess, undo stack isn't cleared immediately in UIProcess.

[Eric Seidel (no email)]

See also bug 20366.