Bug 58987

Summary:

[Qt] Clean the style of our cookie methods

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

Platform

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Enhancement

Keywords:

EasyFix, Qt, QtTriaged

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	kling: review+

Description Benjamin Poulain 2011-04-20 07:03:24 PDT

There are unused variables, invalid char* conversion and useless url conversions.

Comment 1 Benjamin Poulain 2011-04-20 07:08:42 PDT

Created attachment 90338 [details]
Patch

Comment 2 Andreas Kling 2011-04-20 07:32:14 PDT

Comment on attachment 90338 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90338&action=review

Please provide SunSpider numbers.

> Source/WebCore/ChangeLog:13
> +        (WebCore::cookies): foreach() should use ref to const as for Qt.

s/ref to const as/const references/

Comment 3 Benjamin Poulain 2011-04-20 07:47:45 PDT

Committed r84373: <http://trac.webkit.org/changeset/84373>