Bug 58969

Summary: [chromium] Fix artefacts in compositor HUD when resizing
Product: WebKit Reporter: Nat Duca <nduca>
Component: New BugsAssignee: Nat Duca <nduca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, enne, jamesr, nduca
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Description Nat Duca 2011-04-20 00:25:02 PDT 
[chromium] Fix artefacts in compositor HUD when resizing
Comment 1 Nat Duca 2011-04-20 00:27:13 PDT 
Created attachment 90321 [details]
Patch
Comment 2 James Robinson 2011-04-20 00:39:25 PDT 
Comment on attachment 90321 [details]
Patch

Aha!  I blame enne :P
Comment 3 James Robinson 2011-04-20 00:40:16 PDT 
Comment on attachment 90321 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90321&action=review

> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:988
> +    m_headsUpDisplayProgram = adoptPtr(new CCHeadsUpDisplay::Program(m_context.get()));

btw not to pick on you since you didn't do this but our Program impl really should have a static PassOwnPtr<> create() function and a private c'tor
Comment 4 WebKit Commit Bot 2011-04-21 14:19:17 PDT 
The commit-queue encountered the following flaky tests while processing attachment 90321 [details]:

http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2011-04-21 14:22:47 PDT 
Comment on attachment 90321 [details]
Patch

Clearing flags on attachment: 90321

Committed r84546: <http://trac.webkit.org/changeset/84546>
Comment 6 WebKit Commit Bot 2011-04-21 14:22:50 PDT 
All reviewed patches have been landed.  Closing bug.