Bug 58968

Summary: [GTK] Build libWebCore with the gtk sources too
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Description Carlos Garcia Campos 2011-04-20 00:06:53 PDT 
Currently webcore gtk sources are compiled as part of the libwebkitgtk sources, I think they should be moved to libWebCore, since libwebkitgtk already uses libWebCore.la.
Comment 1 Carlos Garcia Campos 2011-04-20 00:10:37 PDT 
Created attachment 90319 [details]
Patch

This change also improves the build time.
Comment 2 Martin Robinson 2011-04-20 08:41:39 PDT 
Comment on attachment 90319 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90319&action=review

> Source/WebCore/ChangeLog:8
> +        [GTK] Build libWebCore with the gtk sources too
> +        https://bugs.webkit.org/show_bug.cgi?id=58968
> +
> +        * GNUmakefile.am: Add webcore gtk sources to libWebCore sources.

Please include in your ChangeLog the motivations for this change, so that people browsing the repository know what's up.
Comment 3 Carlos Garcia Campos 2011-04-20 09:21:48 PDT 
Committed r84381: <http://trac.webkit.org/changeset/84381>
Comment 4 WebKit Review Bot 2011-04-20 15:43:50 PDT 
http://trac.webkit.org/changeset/84381 might have broken WinCairo Debug (Build)