Bug 58968

Summary: [GTK] Build libWebCore with the gtk sources too
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Carlos Garcia Campos
Reported 2011-04-20 00:06:53 PDT
Currently webcore gtk sources are compiled as part of the libwebkitgtk sources, I think they should be moved to libWebCore, since libwebkitgtk already uses libWebCore.la.
Attachments
Patch (2.05 KB, patch)
2011-04-20 00:10 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2011-04-20 00:10:37 PDT
Created attachment 90319 [details] Patch This change also improves the build time.
Martin Robinson
Comment 2 2011-04-20 08:41:39 PDT
Comment on attachment 90319 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90319&action=review > Source/WebCore/ChangeLog:8 > + [GTK] Build libWebCore with the gtk sources too > + https://bugs.webkit.org/show_bug.cgi?id=58968 > + > + * GNUmakefile.am: Add webcore gtk sources to libWebCore sources. Please include in your ChangeLog the motivations for this change, so that people browsing the repository know what's up.
Carlos Garcia Campos
Comment 3 2011-04-20 09:21:48 PDT
Committed r84381: <http://trac.webkit.org/changeset/84381>
WebKit Review Bot
Comment 4 2011-04-20 15:43:50 PDT
http://trac.webkit.org/changeset/84381 might have broken WinCairo Debug (Build)
Note You need to log in before you can comment on or make changes to this bug.