Bug 58950

Summary: Rationalize MacroAssembler branch methods
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, thouraya.andolsi, thouraya.andolsi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
The patch
oliver: review+
fix issues none

Gavin Barraclough
Reported 2011-04-19 17:51:11 PDT
The MacroAssembler currently exposes x86's weird behaviour that the setcc instruction only sets the low 8 bits of a register. Stop that. Having done so, to clarify remove the 'set32' prefix from test & compare instructions - these methods all now set a full 32/64 bit register (Ptr size). The size in the function name should indicate the amount of data being compared. Also split out the 'Condition' enum into 'RelationalCondition' and 'ResultCondition'. The former is used in binary comparison, the latter compares the latter is a unary condition check on the result of an operation.
Attachments
The patch (89.26 KB, patch)
2011-04-19 17:53 PDT, Gavin Barraclough 		oliver: review+
DetailsFormatted DiffDiff
fix issues (33.54 KB, patch)
2011-04-22 09:33 PDT, thouraya 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2011-04-19 17:53:51 PDT
Created attachment 90282 [details] The patch
Oliver Hunt
Comment 2 2011-04-19 18:15:42 PDT
Comment on attachment 90282 [details] The patch rs=me
Gavin Barraclough
Comment 3 2011-04-20 11:44:50 PDT
Fixed in r84399
WebKit Review Bot
Comment 4 2011-04-20 11:57:41 PDT
http://trac.webkit.org/changeset/84399 might have broken Qt Linux ARMv7 Release
thouraya
Comment 5 2011-04-22 09:15:35 PDT
Hello, The patch caused a build problem for SH4 platforms. I created a patch to fix the issue. Should I submit a patch here or create a new bug? Regards, Thouraya.
thouraya
Comment 6 2011-04-22 09:33:18 PDT
Created attachment 90713 [details] fix issues Hello, Attached a patch to fix the issue. Regards, Thouraya.
Gavin Barraclough
Comment 7 2011-04-24 12:51:58 PDT
Comment on attachment 90713 [details] fix issues Looks great!
thouraya
Comment 8 2011-04-25 07:18:58 PDT
Hello, I have a question: the patch can be landed even if the bug is not opened? Regards, Thouraya.
Adam Barth
Comment 9 2011-04-25 11:18:59 PDT
The bug needs to be open for the commit-queue to see the patch.
WebKit Commit Bot
Comment 10 2011-04-25 13:19:21 PDT
Comment on attachment 90713 [details] fix issues Clearing flags on attachment: 90713 Committed r84796: <http://trac.webkit.org/changeset/84796>
Note You need to log in before you can comment on or make changes to this bug.