|Summary:||Rationalize MacroAssembler branch methods|
|Product:||WebKit||Reporter:||Gavin Barraclough <barraclough>|
|Severity:||Normal||CC:||abarth, commit-queue, eric, thouraya.andolsi, thouraya.andolsi, webkit.review.bot|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
Description Gavin Barraclough 2011-04-19 17:51:11 PDT
The MacroAssembler currently exposes x86's weird behaviour that the setcc instruction only sets the low 8 bits of a register. Stop that. Having done so, to clarify remove the 'set32' prefix from test & compare instructions - these methods all now set a full 32/64 bit register (Ptr size). The size in the function name should indicate the amount of data being compared. Also split out the 'Condition' enum into 'RelationalCondition' and 'ResultCondition'. The former is used in binary comparison, the latter compares the latter is a unary condition check on the result of an operation.
Comment 4 WebKit Review Bot 2011-04-20 11:57:41 PDT
http://trac.webkit.org/changeset/84399 might have broken Qt Linux ARMv7 Release
Comment 5 thouraya 2011-04-22 09:15:35 PDT
Hello, The patch caused a build problem for SH4 platforms. I created a patch to fix the issue. Should I submit a patch here or create a new bug? Regards, Thouraya.
Comment 6 thouraya 2011-04-22 09:33:18 PDT
Created attachment 90713 [details] fix issues Hello, Attached a patch to fix the issue. Regards, Thouraya.
Comment 7 Gavin Barraclough 2011-04-24 12:51:58 PDT
Comment on attachment 90713 [details] fix issues Looks great!
Comment 8 thouraya 2011-04-25 07:18:58 PDT
Hello, I have a question: the patch can be landed even if the bug is not opened? Regards, Thouraya.
Comment 9 Adam Barth 2011-04-25 11:18:59 PDT
The bug needs to be open for the commit-queue to see the patch.