Bug 58939

Summary: Removed a use of markDOMObjectWrapper: NodeLists
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric, oliver, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch oliver: review+

Description Geoffrey Garen 2011-04-19 16:21:58 PDT 
Removed a use of markDOMObjectWrapper: NodeLists
Comment 1 Geoffrey Garen 2011-04-19 16:25:14 PDT 
Created attachment 90274 [details]
Patch
Comment 2 Oliver Hunt 2011-04-19 16:28:29 PDT 
Comment on attachment 90274 [details]
Patch

r=me, i'm not liking the repeated CustomToJS stuff though.
Comment 3 Geoffrey Garen 2011-04-19 16:30:06 PDT 
> r=me, i'm not liking the repeated CustomToJS stuff though.

It's fixable, but we'd have to move a bunch of code to an XXXCustom.h file. Moving toJS to the XXXCustom.cpp file seemed like the easier way.
Comment 4 Geoffrey Garen 2011-04-19 16:32:44 PDT 
Committed r84309: <http://trac.webkit.org/changeset/84309>
Comment 5 Geoffrey Garen 2011-04-19 16:34:43 PDT 
(In reply to comment #3)
Actually, another way to fix it would be to add a new "CustomOwner" feature -- that would allow us to avoid CustomToJS while still keeping everything custom in XXXCustom.cpp.
Comment 6 WebKit Review Bot 2011-04-19 16:51:09 PDT 
http://trac.webkit.org/changeset/84309 might have broken Chromium Linux Release
Comment 7 WebKit Review Bot 2011-04-19 17:05:14 PDT 
Attachment 90274 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8470495
Comment 8 WebKit Review Bot 2011-04-19 18:16:26 PDT 
Attachment 90274 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8469538