Bug 58939

Summary: Removed a use of markDOMObjectWrapper: NodeLists
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric, oliver, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch oliver: review+

Geoffrey Garen
Reported 2011-04-19 16:21:58 PDT
Removed a use of markDOMObjectWrapper: NodeLists
Attachments
Patch (8.93 KB, patch)
2011-04-19 16:25 PDT, Geoffrey Garen 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2011-04-19 16:25:14 PDT
Created attachment 90274 [details] Patch
Oliver Hunt
Comment 2 2011-04-19 16:28:29 PDT
Comment on attachment 90274 [details] Patch r=me, i'm not liking the repeated CustomToJS stuff though.
Geoffrey Garen
Comment 3 2011-04-19 16:30:06 PDT
> r=me, i'm not liking the repeated CustomToJS stuff though. It's fixable, but we'd have to move a bunch of code to an XXXCustom.h file. Moving toJS to the XXXCustom.cpp file seemed like the easier way.
Geoffrey Garen
Comment 4 2011-04-19 16:32:44 PDT
Committed r84309: <http://trac.webkit.org/changeset/84309>
Geoffrey Garen
Comment 5 2011-04-19 16:34:43 PDT
(In reply to comment #3) Actually, another way to fix it would be to add a new "CustomOwner" feature -- that would allow us to avoid CustomToJS while still keeping everything custom in XXXCustom.cpp.
WebKit Review Bot
Comment 6 2011-04-19 16:51:09 PDT
http://trac.webkit.org/changeset/84309 might have broken Chromium Linux Release
WebKit Review Bot
Comment 7 2011-04-19 17:05:14 PDT
Attachment 90274 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8470495
WebKit Review Bot
Comment 8 2011-04-19 18:16:26 PDT
Attachment 90274 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8469538
Note You need to log in before you can comment on or make changes to this bug.