Bug 58933 – [chromium] Clamp dirty regions on content layers to layer bounds

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Adrienne Walker]

[chromium] Clamp dirty regions on content layers to layer bounds

[Adrienne Walker]

Created attachment 90266 [details]
Patch

[Adrienne Walker]

This is the WebKit fix for http://crbug.com/79749.

[Vangelis Kokkevis]

Comment on attachment 90266 [details]
Patch

unofficial r+ although it probably needs a test too...

[James Robinson]

Comment on attachment 90266 [details]
Patch

Agree re: test.  We're likely to be mucking about with this code a good bit over the next few weeks and I don't want to rewrite the same bug again without a test.

[Adrienne Walker]

Because this manually fixes both the original bug and another test case that Vangelis found, I'm going to commit this but leave the bug open until I write a test case.

[Stephen White]

(In reply to comment #5)
> Because this manually fixes both the original bug and another test case that Vangelis found, I'm going to commit this but leave the bug open until I write a test case.

Sounds good to me (unofficially).  Thanks very much for the quick fix!

[Adrienne Walker]

Committed r84529: <http://trac.webkit.org/changeset/84529>

[Adrienne Walker]

Good news, everybody! We already had three test cases that demonstrated this bug.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=media%2Fcontrols-styling.html%2Cmedia%2Fvideo-volume-slider.html%2Cmedia%2Fvideo-zoom-controls.html&group=%40ToT%20GPU%20Mesa%20-%20chromium.org

...they were just all marked as IMAGE fail.