Bug 58931

Summary: don't show missing text results for tests that only dump image results
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: dpranke, eric, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch eric: review+

Ojan Vafai
Reported 2011-04-19 15:16:15 PDT
don't show missing text results for tests that only dump image results
Attachments
Patch (3.00 KB, patch)
2011-04-19 15:17 PDT, Ojan Vafai 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2011-04-19 15:17:24 PDT
Created attachment 90263 [details] Patch
Eric Seidel (no email)
Comment 2 2011-04-19 15:28:35 PDT
Comment on attachment 90263 [details] Patch I didn't know we had tests which only dumped images?
Dirk Pranke
Comment 3 2011-04-19 15:33:06 PDT
It is possible for any given test to be missing either text, audio, or images (but it should always produce either text or audio). It should not be possible for a test to only produce image data.
Ojan Vafai
Comment 4 2011-04-19 15:38:40 PDT
Oh, I'm wrong. It looks like if the text result passes and the image result is missing, we'll only dump the image result.
Dirk Pranke
Comment 5 2011-04-19 16:20:27 PDT
to further clarify, even though a test will always produce either text or audio, it will only save the output into the layout-test-results directory if the output didn't match the expected content. Ojan's patch is concerned with the saved output (the -actual.* files), not the produced output that lives in memory. Patch LGTM as well.
Ojan Vafai
Comment 6 2011-04-19 16:43:13 PDT
Committed r84313: <http://trac.webkit.org/changeset/84313>
Note You need to log in before you can comment on or make changes to this bug.