| Summary: | don't show missing text results for tests that only dump image results | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ojan Vafai <ojan> | ||||
| Component: | New Bugs | Assignee: | Ojan Vafai <ojan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dpranke, eric, tony | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Ojan Vafai
2011-04-19 15:16:15 PDT
Created attachment 90263 [details]
Patch
Comment on attachment 90263 [details]
Patch
I didn't know we had tests which only dumped images?
It is possible for any given test to be missing either text, audio, or images (but it should always produce either text or audio). It should not be possible for a test to only produce image data. Oh, I'm wrong. It looks like if the text result passes and the image result is missing, we'll only dump the image result. to further clarify, even though a test will always produce either text or audio, it will only save the output into the layout-test-results directory if the output didn't match the expected content. Ojan's patch is concerned with the saved output (the -actual.* files), not the produced output that lives in memory. Patch LGTM as well. Committed r84313: <http://trac.webkit.org/changeset/84313> |