Bug 58927

Summary: Move and rename GLES2Canvas
Product: WebKit Reporter: Stephen White <senorblanco>
Component: CanvasAssignee: Stephen White <senorblanco>
Status: RESOLVED FIXED    
Severity: Normal CC: kbr, mdelaney7
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch kbr: review+

Stephen White
Reported 2011-04-19 14:11:28 PDT
GLES2Canvas isn't really a canvas; it's a context. It also has no particular ties to platform/graphics/chromium, and should live in platform/graphics/gpu where all the shaders are.
Attachments
Patch (105.00 KB, patch)
2011-04-19 14:26 PDT, Stephen White 		kbr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Stephen White
Comment 1 2011-04-19 14:26:38 PDT
Created attachment 90254 [details] Patch
Kenneth Russell
Comment 2 2011-04-19 15:48:31 PDT
Comment on attachment 90254 [details] Patch This looks fine to me. Usually this sort of renaming is done with Tools/Scripts/do-webcore-rename, but I don't think that script supports moving files between subdirectories. It's clear that this patch contains only the straightforward renaming.
Stephen White
Comment 3 2011-04-19 17:46:49 PDT
(In reply to comment #2) > (From update of attachment 90254 [details]) > This looks fine to me. Usually this sort of renaming is done with Tools/Scripts/do-webcore-rename, but I don't think that script supports moving files between subdirectories. It's clear that this patch contains only the straightforward renaming. Thanks! I didn't know about that script.
Stephen White
Comment 4 2011-04-20 08:02:33 PDT
Committed r84374: <http://trac.webkit.org/changeset/84374>
Note You need to log in before you can comment on or make changes to this bug.