Bug 58919

Summary: WebKit2: Merge SelectionState and TextInputState
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: HTML EditingAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: enrica
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.6   
Attachments:
Description Flags
proposed patch adele: review+

Alexey Proskuryakov
Reported 2011-04-19 12:45:55 PDT
These are almost the same. SelectionState is only updated asynchronously, while TextInputState is updated synchronously, and is only valid while a key event is being processed. That's confusing. We can always keep the latest known state in the one place.
Attachments
proposed patch (66.88 KB, patch)
2011-04-19 12:50 PDT, Alexey Proskuryakov 		adele: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2011-04-19 12:50:25 PDT
Created attachment 90239 [details] proposed patch
Enrica Casucci
Comment 2 2011-04-19 13:41:52 PDT
Comment on attachment 90239 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=90239&action=review The patch looks good to me. I like the way the code gets simplified. I don't understand why EditorState.h appears twice looking at the review, but it is probably a bug in the review tool. The only comment I have is the copyright year. Also, it appears there are problems in applying the patch for the qt build. > Source/WebKit2/Shared/EditorState.h:3 > + * Copyright 2011.
Alexey Proskuryakov
Comment 3 2011-04-19 15:54:13 PDT
Committed <http://trac.webkit.org/changeset/84304>.
Note You need to log in before you can comment on or make changes to this bug.