Bug 58919

Summary:

WebKit2: Merge SelectionState and TextInputState

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

HTML Editing

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

enrica

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.6

Attachments:

Description	Flags
proposed patch	adele: review+

Description Alexey Proskuryakov 2011-04-19 12:45:55 PDT

These are almost the same. SelectionState is only updated asynchronously, while TextInputState is updated synchronously, and is only valid while a key event is being processed.

That's confusing. We can always keep the latest known state in the one place.

Comment 1 Alexey Proskuryakov 2011-04-19 12:50:25 PDT

Created attachment 90239 [details]
proposed patch

Comment 2 Enrica Casucci 2011-04-19 13:41:52 PDT

Comment on attachment 90239 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90239&action=review

The patch looks good to me. I like the way the code gets simplified. I don't understand why EditorState.h appears twice looking at the review, but it is probably a bug in the review tool. The only comment I have is the copyright year.
Also, it appears there are problems in applying the patch for the qt build.

> Source/WebKit2/Shared/EditorState.h:3
> + *

Copyright 2011.

Comment 3 Alexey Proskuryakov 2011-04-19 15:54:13 PDT

Committed <http://trac.webkit.org/changeset/84304>.