Bug 58887 – [Qt] Add possibility to run and set URLLoader from the browsers

• Component: Tools / Tests
• Status: RESOLVED INVALID

[Zoltan Horvath]

Add an URLLoader widget to make it possible to run and set URLLoader from the browsers.
Fix command line URL parameter handling in case of -robot-timeout and -robot-extra-time.

[Zoltan Horvath]

Created attachment 90187 [details]
proposed patch

[WebKit Review Bot]

Attachment 90187 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/MiniBrowser/qt/B..." exit_code: 1

Tools/QtTestBrowser/launcherwindow.h:66:  Alphabetical sorting problem.  [build/include_order] [4]
Tools/QtTestBrowser/UrlLoaderWidget.cpp:28:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 2 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Zoltan Horvath]

Comment on attachment 90187 [details]
proposed patch

I will fix style issues before land.

[Andreas Kling]

Comment on attachment 90187 [details]
proposed patch

This seems really unnecessary, would anyone really use it? (Given that it's available on the command-line already.)
r- because I don't see the usecase. Feel free to explain it and reset r?

[Andras Becsi]

(In reply to comment #4)
> (From update of attachment 90187 [details])
> This seems really unnecessary, would anyone really use it? (Given that it's available on the command-line already.)
> r- because I don't see the usecase. Feel free to explain it and reset r?

I already use this patch for collecting profile data.

My workflow is browsing various sites, then loading a list of selected pages with the URLLoader, then browsing again and loading another list, all this without losing the caches in between.

I think this is kind of a use-case for this feature so I would appreciate it.

[Zoltan Horvath]

Created attachment 110359 [details]
updated to TOT

mwenge also told me on IRC this patch is useful, so I updated it.

[Early Warning System Bot]

Comment on attachment 110359 [details]
updated to TOT

Attachment 110359 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10009952

[Andreas Kling]

Comment on attachment 110359 [details]
updated to TOT

Since MiniBrowser is being rewritten in QML, this needs updating. :)

[Jocelyn Turcotte]

=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.