Bug 58846

Summary: Re-add a null check lost in r83081
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit2Assignee: Alexey Proskuryakov <ap>
Severity: Normal CC: rsesek
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.6   
Description Flags
proposed patch mjs: review+

Description Alexey Proskuryakov 2011-04-18 15:49:32 PDT
A null check was lost in selectedRange(), causing crashes.
Comment 1 Alexey Proskuryakov 2011-04-18 15:51:51 PDT
Created attachment 90109 [details]
proposed patch
Comment 2 Robert Sesek 2011-04-18 15:55:38 PDT
An alternative would be to return false in TextIterator::locationAndLengthFromRange(), which is what WebPage::getLocationAndLengthFromRange used to do.

Sorry that I introduced so many regressions :/
Comment 3 Maciej Stachowiak 2011-04-18 15:58:07 PDT
Comment on attachment 90109 [details]
proposed patch

Comment 4 Alexey Proskuryakov 2011-04-18 16:07:57 PDT
Committed <http://trac.webkit.org/changeset/84202>.