Bug 58822

Summary: 100% reproducible crash when right-clicking any element in Web Inspector on any page
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit2Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, buildbot, eric, webkit.review.bot
Priority: P1 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.6   
Attachments:
Description Flags
proposed fix
none
with build fixes
none
proposed fix timothy: review+

Alexey Proskuryakov
Reported 2011-04-18 13:47:47 PDT
Steps to reproduce: 1. Go to http://webkit.org 2. Open the web inspector 3. Scroll to the top of the inspector so you can see this page's <html> element. Don't click on it. 4. Right click and choose Add Attribute. <rdar://problem/9279698>
Attachments
proposed fix (64.79 KB, patch)
2011-04-18 13:57 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
with build fixes (68.68 KB, patch)
2011-04-18 16:06 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
proposed fix (2.18 KB, patch)
2011-04-19 14:13 PDT, Alexey Proskuryakov 		timothy: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2011-04-18 13:57:49 PDT
Created attachment 90087 [details] proposed fix
WebKit Review Bot
Comment 2 2011-04-18 15:05:07 PDT
Attachment 90087 [details] did not build on mac: Build output: http://queues.webkit.org/results/8474043
Build Bot
Comment 3 2011-04-18 15:53:07 PDT
Attachment 90087 [details] did not build on win: Build output: http://queues.webkit.org/results/8475045
Alexey Proskuryakov
Comment 4 2011-04-18 16:06:27 PDT
Created attachment 90111 [details] with build fixes
Alexey Proskuryakov
Comment 5 2011-04-19 12:46:40 PDT
Comment on attachment 90111 [details] with build fixes I want to fix this differently, and also to split refactoring into a separate patch.
Alexey Proskuryakov
Comment 6 2011-04-19 14:13:50 PDT
Created attachment 90251 [details] proposed fix
Alexey Proskuryakov
Comment 7 2011-04-19 14:37:33 PDT
Committed <http://trac.webkit.org/changeset/84297>.
WebKit Review Bot
Comment 8 2011-04-19 15:35:49 PDT
http://trac.webkit.org/changeset/84297 might have broken Qt Linux Release
Note You need to log in before you can comment on or make changes to this bug.