Bug 58820

Summary:

[Qt] QtInstance method cache ownership rules are unclear

Product:

WebKit

Reporter:

Oliver Hunt <oliver>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarcelo, webkit-ews

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
same as earlier, with build fix	kling: review+

Oliver Hunt

Reported 2011-04-18 13:31:41 PDT

I've temporarily made a cache use Global<> however it may be possible to make that produce ref cycles. I'm also unsure how correct the method cache is -- if more than one JS object uses the same backing instance the two objects may share function instances. I don't know if this is possible, or even desired, just recording the observation.

Attachments
Patch (5.22 KB, patch) 2011-04-19 11:45 PDT, Oliver Hunt	no flags	Details Formatted Diff Diff
Patch (4.34 KB, patch) 2011-04-19 12:38 PDT, Oliver Hunt	no flags	Details Formatted Diff Diff
same as earlier, with build fix (4.43 KB, patch) 2011-04-19 13:24 PDT, Oliver Hunt	kling: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.